Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support dynamic templateref naming. Fixes: #10542 #12842

Merged
merged 7 commits into from
Apr 12, 2024
Merged

feat: support dynamic templateref naming. Fixes: #10542 #12842

merged 7 commits into from
Apr 12, 2024
+94 −12

Conversation

shuangkun
Copy link
Member

@shuangkun shuangkun commented Mar 25, 2024 •
edited
Loading

Support dynamic templateref naming

Fixes #10542

Motivation

Modifications

Verification

@shuangkun shuangkun marked this pull request as draft March 25, 2024 13:57
@shuangkun shuangkun closed this Mar 26, 2024
@shuangkun shuangkun reopened this Mar 26, 2024
@shuangkun shuangkun force-pushed the feat/DynamicTemplateRefNaming branch from 3849027 to 98902b9 Compare March 26, 2024 06:28
@shuangkun shuangkun closed this Mar 26, 2024
@shuangkun shuangkun reopened this Mar 26, 2024
@shuangkun shuangkun closed this Mar 26, 2024
@shuangkun shuangkun reopened this Mar 26, 2024
@shuangkun shuangkun closed this Mar 29, 2024
@shuangkun shuangkun reopened this Mar 29, 2024
@shuangkun shuangkun closed this Mar 31, 2024
@shuangkun shuangkun reopened this Mar 31, 2024
@shuangkun
feat: support dynamic templateRef naming. Fixes: argoproj#10542
64f60ef 
Signed-off-by: shuangkun <tsk2013uestc@163.com>
@shuangkun
test: test e2e
ff250a6 
Signed-off-by: shuangkun <tsk2013uestc@163.com>
@shuangkun
fix: change TestTemplateExecutor.
c793f7a 
Signed-off-by: shuangkun <tsk2013uestc@163.com>
@shuangkun
fix: test
292dc70 
Signed-off-by: shuangkun <tsk2013uestc@163.com>
@shuangkun
fix: remove noneed code
d11ae37 
Signed-off-by: shuangkun <tsk2013uestc@163.com>
@shuangkun shuangkun force-pushed the feat/DynamicTemplateRefNaming branch from 98902b9 to d11ae37 Compare April 2, 2024 11:13
@shuangkun
fix: lint
6e43e7d 
Signed-off-by: shuangkun <tsk2013uestc@163.com>
@shuangkun
fix: ut
2484a53 
Signed-off-by: shuangkun <tsk2013uestc@163.com>
@shuangkun shuangkun marked this pull request as ready for review April 2, 2024 13:21
@shuangkun shuangkun mentioned this pull request Apr 4, 2024
Closed
6 tasks
tczhao
tczhao reviewed Apr 6, 2024
View reviewed changes
Copy link
Member

@tczhao tczhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems the current code already resolves those templates just we never had them in the verify code, correct?

workflow/controller/operator_workflow_template_ref_test.go Show resolved Hide resolved
@shuangkun
Copy link
Member Author

Seems the current code already resolves those templates just we never had them in the verify code, correct?

Yes, "resolveReferences/resolveDependencyReferences" is execute before "expandStep/expandTask". So item will be resolved before executeTemplate.

tczhao
tczhao approved these changes Apr 8, 2024
View reviewed changes
Copy link
Member

@tczhao tczhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tczhao tczhao self-assigned this Apr 8, 2024
@terrytangyuan terrytangyuan merged commit 76b2a3f into argoproj:main Apr 12, 2024
27 checks passed
@agilgur5 agilgur5 added this to the v3.6.0 milestone Apr 12, 2024
@tczhao tczhao mentioned this pull request May 1, 2024
Closed
6 tasks
@agilgur5 agilgur5 mentioned this pull request Aug 31, 2024
Open
4 tasks
tczhao pushed a commit to tczhao/argo that referenced this pull request Oct 30, 2024
@shuangkun @tczhao
feat: support dynamic templateref naming. Fixes: argoproj#10542 (argo…
f57f919 
…proj#12842)

Signed-off-by: shuangkun <tsk2013uestc@163.com>
@shuangkun shuangkun mentioned this pull request Nov 1, 2024
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tczhao tczhao tczhao approved these changes

@terrytangyuan terrytangyuan terrytangyuan approved these changes

Assignees

@tczhao tczhao

Labels
area/templating Templating with `{{...}}` area/workflow-templates
Projects
None yet
Milestone
v3.6.0
Development

Successfully merging this pull request may close these issues.

Support dynamic templateRef naming
4 participants
@shuangkun @terrytangyuan @tczhao @agilgur5