Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct order in artifactGC error log message #12935

Merged

Conversation

static-moonlight
Copy link
Contributor

@static-moonlight static-moonlight commented Apr 15, 2024

fix an error log message, which currently uses a wrong order of parameter, as mention in #12845 (point 5).

Signed-off-by: static-moonlight <107991124+static-moonlight@users.noreply.github.com>
@static-moonlight static-moonlight changed the title fix order of parameters for error log message fix: fix order of parameters for error log message Apr 15, 2024
@agilgur5 agilgur5 changed the title fix: fix order of parameters for error log message fix: correct order in artifactGC error log message Apr 15, 2024
@agilgur5 agilgur5 added area/artifacts S3/GCP/OSS/Git/HDFS etc area/gc Garbage collection, such as TTLs, retentionPolicy, delays, and more labels Apr 15, 2024
@agilgur5 agilgur5 self-assigned this Apr 15, 2024
@agilgur5
Copy link
Contributor

as mention in #12845 (point 5).

yea thanks for noticing and pointing that out!
for reference, I found the specific line number in the code in #12845 (reply in thread)

Copy link
Contributor

@agilgur5 agilgur5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the error log!

@agilgur5 agilgur5 merged commit ea5410a into argoproj:main Apr 15, 2024
29 of 30 checks passed
@agilgur5 agilgur5 added this to the v3.5.x patches milestone Apr 19, 2024
agilgur5 pushed a commit that referenced this pull request Apr 19, 2024
Signed-off-by: static-moonlight <107991124+static-moonlight@users.noreply.github.com>
(cherry picked from commit ea5410a)
@agilgur5
Copy link
Contributor

Backported cleanly to release-3.5 as 909fdaa

isubasinghe pushed a commit to isubasinghe/argo-workflows that referenced this pull request May 6, 2024
Signed-off-by: static-moonlight <107991124+static-moonlight@users.noreply.github.com>
isubasinghe pushed a commit to isubasinghe/argo-workflows that referenced this pull request May 7, 2024
Signed-off-by: static-moonlight <107991124+static-moonlight@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/artifacts S3/GCP/OSS/Git/HDFS etc area/gc Garbage collection, such as TTLs, retentionPolicy, delays, and more
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants