fix(ui): try retrieving live workflow first then archived #12972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryancurrah
commented
Apr 24, 2024
ui/src/app/workflows/components/workflow-details/workflow-details.tsx
Outdated
Show resolved
Hide resolved
agilgur5
changed the title
agilgur5
reviewed
Apr 24, 2024
ui/src/app/workflows/components/workflow-details/workflow-details.tsx
Outdated
Show resolved
Hide resolved
ryancurrah
force-pushed
the
workflow-details-page-makes-unnecessary-archived-request
branch
from
cc237cc
to
d080165
Compare
Retrieving an archived workflow is the fallback now. Curently an error appears when loading a workflow because archived workflows are not enabled and the ui tries to get the archived workflow first. Related issue: argoproj#12814 and Slack thread: https://cloud-native.slack.com/archives/C01QW9QSSSK/p1710600357875049\?thread_ts\=1710510295.856659\&cid\=C01QW9QSSSK Signed-off-by: Ryan Currah <ryan@currah.ca>
ryancurrah
force-pushed
the
workflow-details-page-makes-unnecessary-archived-request
branch
from
d080165
to
ae5a92a
Compare
agilgur5
reviewed
Apr 24, 2024
Signed-off-by: Ryan Currah <ryan@currah.ca>
agilgur5
approved these changes
Apr 24, 2024
ryancurrah
deleted the
workflow-details-page-makes-unnecessary-archived-request
branch
agilgur5
pushed a commit
that referenced
this pull request
Apr 24, 2024
Signed-off-by: Ryan Currah <ryan@currah.ca> (cherry picked from commit 9e1432a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retrieving an archived workflow is the fallback now.
Related Slack thread: https://cloud-native.slack.com/archives/C01QW9QSSSK/p1710600357875049\?thread_ts\=1710510295.856659\&cid\=C01QW9QSSSK
Fixes #12814
Motivation
Currently an error appears when loading a workflow because archived workflows are not enabled and the ui tries to get the archived workflow first.
Modifications
Changed the order in which workflows are retrieved from the back end.
Verification
None, not sure how to verify at the moment.