fix(release): set $DOCKER_CONFIG
if unset
#13155
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12791 (comment)
Motivation
Per the linked comment above, it seems like
Azure/docker-login
may have set this env var and so when that was changed todocker/login-action
, this line errored outModifications
$DOCKER_CONFIG
in case it is unset~/.docker/config.json
(can also confirm locally)Verification
This new line runs locally for me:
and
$DOCKER_CONFIG
is unset without itBut testing the entire GHA workflow is unfortunately very non-trivial 😕