-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(controller): node message should be updated when lock msg changed #13648
Conversation
/hold |
05b0ed9
to
104058f
Compare
/hold cancel |
@chengjoey FYI: I entered #13660 to fix the flaky tests. After that's merged, click the "Update branch" button at the bottom of the PR |
@chengjoey is this ready for review, I'm unsure of what you meant by this comment? |
yeah, it is ready for review, since I didn't add the test at first, I used |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a follow up to this it would be possible to list all of the failing locks rather than just the first, so if you feel like doing that it would be useful.
4a77ddb
to
ffe5f17
Compare
ffe5f17
to
c741792
Compare
This needs the linter issue fixing @chengjoey |
Signed-off-by: joey <zchengjoey@gmail.com>
c741792
to
5665d83
Compare
thanks @Joibel done |
Fixes #13629
Motivation
When the sync lock is not released, the latest lock-msg is always used as the node message