feat(artifactGC): include env, volumes, volumeMounts. Fixes #9746

[mrkschneider]

Fixes #9746

Motivation

This PR allows to provide credentials for artifact garbage collection via environment variables or mounted volumes.

Modifications

• Introduce three new fields to ArtifactGC struct: Env,Volumes,VolumeMounts
• The new fields are taken into account when grouping artifacts by credential set in artifact_gc.go
• The new fields are also added to the cleanup pod performing garbage collection

Verification

• added new fields to existing unit tests
• submitted workflows with new fields and checked credential grouping + mounting of credentials in cleanup pod

[mrkschneider]

Build of argocli is failing in the pull request, though it succeeds locally on my machine. Can you please give me any advice on how to resolve the issue?

[agilgur5]

Build of argocli is failing in the pull request

That appears to a new bug on main from #13343. It's unrelated to your change so you can ignore it, but will need to rebase once that is fixed.

[MasonM]

FYI: #13730 should fix the build failures

[mrkschneider]

Build of argocli is failing in the pull request

That appears to a new bug on main from #13343. It's unrelated to your change so you can ignore it, but will need to rebase once that is fixed.

rebasing on main fixed it, thanks!