fix(deps): revert React 18 upgrade back to React 16 #13821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agilgur5
added
type/dependencies
- not all of our deps are compatible with React 18 and so this caused many warnings as well as some bugs - those need more updates, primarily breaking changes within `argo-ui` or decoupling the dependency on `argo-ui` - the main purpose of the upgrade was to be able to upgrade `swagger-ui-react`, which had an alternate React 16 compatible path and has now been removed from the UI codebase entirely - so the upgrade is no longer necessary for that purpose Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
agilgur5
force-pushed
the
fix-deps-downgrade-react-revert
branch
from
51cfc19 to
7bae3c1
Compare
This has been rebased on top now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13410 per #13069 (review), effectively reverting the React upgrade part of #13069
Motivation
not all of our deps are compatible with React 18 and so this caused many warnings (during install and in the browser console) as well as some bugs (fix(ui): handle React 18 batching for "Submit" button on details page. Fixes #13453 #13593)
argo-uior decoupling the dependency onargo-uireact-router-domfrom 4.3.1 to 6.20.0 argo-ui#481 (comment) with regard toreact-routerinargo-ui, although that's not the only dep relying on old React inargo-ui(react-form,react-autocomplete, and some of the components are too IIRC)the main purpose of the upgrade was to be able to upgrade
swagger-ui-react, which had an alternate React 16 compatible path and has now been removed from the UI codebase entirely as of refactor(deps)!: removeswagger-ui-react#13818Modifications
renderchanges to use React 16 syntaxVerification
yarn install, only the expected ones from transitive deps or incorrect peerDeps of deps per javascript dependency warnings -- mostly due to incompatible React #13410 (comment)make start UI=true, functions fine with a few actions.yarn buildandyarn lintpass.