docs: fix refs to stopStrategy.expression
#13896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The documentation in several places refers to `stopStrategy.condition` but the property is actually `expression`. Signed-off-by: Carlos Rodriguez-Fernandez <carlosrodrifernandez@gmail.com>
carlosrodfern
requested review from
terrytangyuan and
sarabala1979
as code owners
Joibel
approved these changes
Nov 13, 2024
Joibel
pushed a commit
that referenced
this pull request
Nov 22, 2024
Signed-off-by: Carlos Rodriguez-Fernandez <carlosrodrifernandez@gmail.com> (cherry picked from commit f73e7f9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation in several places refers to
stopStrategy.conditionbut the property is actuallyexpression.Motivation
A documentation correction.
Modifications
I updated all references to
stopStrategy.conditionin docs (mdand code) to bestopStrategy.expression, which is the correct prop.Verification