Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move s3 pkg from argoproj to workflow repo. Part of #14312 #14315

Merged
merged 1 commit into from
Mar 21, 2025

Conversation

shuangkun
Copy link
Member

Move s3 pkg back to improve maintainability.

For #14312

Motivation

Modifications

Verification

Documentation

…j#14312

Signed-off-by: shuangkun <tsk2013uestc@163.com>
@shuangkun
Copy link
Member Author

/retest

3 similar comments
@shuangkun
Copy link
Member Author

/retest

@shuangkun
Copy link
Member Author

/retest

@shuangkun
Copy link
Member Author

/retest

Copy link
Member

@tczhao tczhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you comment on what validation have you performed?

@shuangkun
Copy link
Member Author

Could you comment on what validation have you performed?

During the process, I felt that there were not many changes.
I just added code and changed the function call name.
So I feel that this refactoring should not contain breaking changes.
All the original tests can pass, and then I submit the normal workflow to run.

@tczhao tczhao merged commit 9c07357 into argoproj:main Mar 21, 2025
98 of 106 checks passed
jakkubu pushed a commit to splunk/argo-workflows that referenced this pull request Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants