Fixes incorrect parameters in stored templates #1725
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simster7
commented
Nov 1, 2019
Comment on lines
+164
to
+168
| // Store templates | ||
| for _, template := range woc.wf.Spec.Templates { | ||
| storedTemplateName := woc.getStoredTemplateName(template.TemplateRef, template.Name, woc.tmplCtx, &wfv1.Template{Template: template.Name}) | ||
| woc.storeTemplate(storedTemplateName, &template) | ||
| } |
There was a problem hiding this comment.
Store unresolved templates during one-time validation
simster7
commented
Nov 1, 2019
| } else { | ||
| return tmplCtx.WithTemplateBase(woc.wf), resolvedTemplate, nil | ||
| } | ||
| unresolvedTemplate := woc.wf.GetStoredOrLocalTemplate(node) |
There was a problem hiding this comment.
Template will always need to be resolved when querying it.
|
Thank you for trying to fix the issue. I talked with @jessesuen and @sarabala1979 and concluded that we should remove input/arguments resolving of nested templates and store all the intermediate templates instead because this feature is not expected, then we can simplify the logic and it will hopefully fix all the issues happening right now. |
|
@dtaniwaki Are you currently working on the fix? |
|
I’m working on fixing the merging strategy of nested templates. |
|
Closed in favor of #1744 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1713. Approach was to store templates before resolution, and to do so all at once during the one-time validation sequence.
Currently not fully tested (hence why this is a Draft PR), just looking for initial feedback on the implementation.