Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to go modules #1815

Closed
wants to merge 3 commits into from
Closed

Migrate to go modules #1815

wants to merge 3 commits into from

Conversation

ian-howell
Copy link
Contributor

@ian-howell ian-howell commented Dec 3, 2019 •
edited by alexec
Loading

This PR does a handful of impactful things.

  1. The Prometheus version has been updated from v0.8.0 to v1.0.0. This was required to make the go-mod migration smoother.
  2. Dependency management is migrated from dep to go modules.
  3. The Go version is bumped from Go1.11 to Go1.13

I will gladly put the Prometheus update in its own PR if necessary. I also have no problem with moving the Go version bump to a separate PR.

See #1375

@ian-howell
Update Prometheus to v1.0.0
7628120
@ian-howell
Migrate to go modules
78294ed 
This commit also takes the opportunity to bumb the go version to 1.13
@ian-howell
Remove dep from CI
94007a2
@sarabala1979 sarabala1979 added this to the v2.6 milestone Dec 4, 2019
@simster7 simster7 mentioned this pull request Dec 10, 2019
Closed
@alexec alexec self-assigned this Jan 2, 2020
alexec
alexec requested changes Jan 2, 2020
View reviewed changes
Copy link
Contributor

@alexec alexec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fantastic. We'd love to support Go 1.13 and Go modules. Can I please request:

  1. Update the PR title to note that we upgrade to Go 1.13.
  2. Sync with master and make sure all checks are green.

@alexec
Copy link
Contributor

alexec commented Jan 30, 2020

Closing in favor of #2097

@alexec alexec closed this Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexec alexec alexec requested changes

Assignees

@alexec alexec

Labels
None yet
Projects
None yet
Milestone
v2.6
Development

Successfully merging this pull request may close these issues.
3 participants
@ian-howell @alexec @sarabala1979