feat(controller): Add support for Docker workflow executor for Windows nodes #3301
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Argoexec already works with Windows Containers but didn't support
docker
workflow executor yet as Windows Containers require a different way of mounting the Docker socket (see kubernetes/kubernetes#69484):\\.\pipe\docker_engine
null
false
I adapted the workflow controller to allow for different volume setups for Windows or Linux Steps of a workflow. When the following
nodeSelector
entry is present for a step in a workflow, then the volume setup for Windows is used, else the setup for Linux is used:I also adapted the documentation as you not longer need to use the
kubelet
workflow executor.Checklist:
"fix(controller): Updates such and such. Fixes #1234"
.