Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(controller): Workflows progress. Closes #2717 #4015

Closed
wants to merge 62 commits into from

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Sep 14, 2020

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed the CLA.
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

Closes #2717

Changes

This PR adds:

  • Code that estimates workflow duration based on previous runs of the same workflow template.
  • Adds small "progress lines" to the UI when the workflow is running indicating its progress vs estimated.
  • Changes the blue node running icon so that it either (a) spins as usual or (b) fills ups as progressing.
  • Shows "Progress: N/M" in CLI watch and UI.
  • Populate all nodes resource duration.
  • Watch pod logs for #argo progress=N/M message="m" and update nodes with those values.

Screenshots

Change the spinning notched circle to fill up.

Screenshot 2020-09-18 at 08 22 18

workflo-list
node-details
Screenshot 2020-09-18 at 21 55 34

@alexec alexec closed this Sep 14, 2020
@alexec alexec reopened this Sep 18, 2020
@alexec alexec changed the title feat: Automatic workflows duration prediction. Closes #2717 feat(controller): Automatic workflows duration prediction. Closes #2717 Sep 18, 2020
@alexec alexec closed this Sep 21, 2020
@alexec alexec reopened this Sep 23, 2020
@alexec alexec changed the title feat(controller): Workflows progress & duration estimation. Closes #2717 feat(controller): Workflows progress. Closes #2717 Sep 23, 2020
@alexec alexec added this to the v2.13 milestone Sep 30, 2020
@alexec alexec closed this Sep 30, 2020
@alexec alexec modified the milestones: v2.13, v2.12 Sep 30, 2020
@alexec alexec reopened this Oct 2, 2020
@alexec
Copy link
Contributor Author

alexec commented Oct 2, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatic workflow duration prediction Support progress and/or rate indication
1 participant