Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Adding -o short option for argocli get command #4222

Closed
wants to merge 4 commits into from
Closed

fix: Adding -o short option for argocli get command #4222

wants to merge 4 commits into from

Conversation

sanoojm
Copy link
Contributor

@sanoojm sanoojm commented Oct 6, 2020 •
edited
Loading

Fixes: #3090 Add -o short option for argocli get command

Example:

$ argo get whalesay-zxjmr -o short
STEP               TEMPLATE  PODNAME         DURATION  MESSAGE            NODENAME
 ◷ whalesay-zxjmr  whalesay  whalesay-zxjmr  2d        ContainerCreating  minikube

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@sanoojm sanoojm changed the title Adding -o short option for argocli get command Fix: Adding -o short option for argocli get command Oct 6, 2020
@sanoojm sanoojm changed the title Fix: Adding -o short option for argocli get command fix: Adding -o short option for argocli get command Oct 6, 2020
alexec
alexec reviewed Oct 6, 2020
View reviewed changes
cmd/argo/commands/get.go
@@ -189,6 +189,8 @@ func printWorkflowHelper(wf *wfv1.Workflow, getArgs getFlags) string {
// apply a dummy FgDefault format to align tab writer with the rest of the columns
if getArgs.output == "wide" {
_, _ = fmt.Fprintf(w, "%s\tTEMPLATE\tPODNAME\tDURATION\tARTIFACTS\tMESSAGE\tRESOURCESDURATION\tNODENAME\n", ansiFormat("STEP", FgDefault))
} else if getArgs.output == "short" {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unit test?

alexec
alexec requested changes Oct 8, 2020
View reviewed changes
Copy link
Contributor

@alexec alexec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a unit test.

@alexec
Copy link
Contributor

alexec commented Nov 19, 2020

Bump! Close or continue?

@alexec alexec removed their assignment Nov 30, 2020
@alexec
Copy link
Contributor

alexec commented Dec 1, 2020

Closing pending engagement from PR creator. We can always re-open.

@alexec alexec closed this Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexec alexec alexec requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add -o short option for argocli get command
4 participants
@sanoojm @CLAassistant @alexec @sanoojss