Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update argo-server.md #4306

Merged
merged 1 commit into from
Oct 16, 2020
Merged

Update argo-server.md #4306

merged 1 commit into from
Oct 16, 2020

Conversation

omerfsen
Copy link
Contributor

  1. Remove LoadBalancer change on SVC
  2. Edit deployment manifest to match to install.yaml
  3. Modify path and rewrite rule

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • My organization is added to USERS.md.
  • I've signed the CLA.
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.

1. Remove LoadBalancer change on SVC
2. Edit deployment manifest to match to install.yaml
3. Modify path and rewrite rule
@CLAassistant
Copy link

CLAassistant commented Oct 16, 2020

CLA assistant check
All committers have signed the CLA.

@jessesuen jessesuen merged commit 240cd79 into argoproj:master Oct 16, 2020
@jessesuen
Copy link
Member

Thank you!

alexcapras pushed a commit to alexcapras/argo that referenced this pull request Nov 12, 2020
Signed-off-by: Alex Capras <alexcapras@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants