Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dependencies): Update k8s dependencies to 19.3. Fixes #4425 #4426

Closed

Conversation

NikeNano
Copy link
Contributor

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • My organization is added to USERS.md.
  • I've signed the CLA.
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.

@NikeNano NikeNano marked this pull request as draft October 31, 2020 07:49
@alexec
Copy link
Contributor

alexec commented Oct 31, 2020

This seems like something we want to target for v3. As a result we’d also need to update Argo events.

@NikeNano
Copy link
Contributor Author

NikeNano commented Oct 31, 2020

This seems like something we want to target for v3. As a result we’d also need to update Argo events.

ok, will take a look at evens when I succeed with workflows :). When is the target for v3 @alexec ?

@animeshsingh
Copy link

animeshsingh commented Dec 4, 2020

@NikeNano @alexec when is v3 targeted? We also have a blocker dependency on moving to k8s client higher version asap.

cc @Tomcli

@NikeNano
Copy link
Contributor Author

NikeNano commented Dec 5, 2020

@NikeNano when is v3 targeted? We also have a blocker dependency on moving to k8s client higher version asap.

Dont know, I try to look at this from time to time, but a lot of small things that needs to be updated @animeshsingh

@alexec alexec linked an issue Dec 20, 2020 that may be closed by this pull request
@alexec alexec added this to the v3.0 milestone Dec 20, 2020
@alexec
Copy link
Contributor

alexec commented Dec 20, 2020

v3 is target end of January. We should get this PR into that release.

@alexec
Copy link
Contributor

alexec commented Jan 3, 2021

See #4810

@alexec alexec closed this Jan 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade go-client to v1.19 Update k8s.io/api, k8s.io/apimachinery and k8s.io/client-go
3 participants