fix: executor/pns containerid prefix fix #4555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lennart Kindermann <lennart.kindermann@cloudseeds.de>
Signed-off-by: Lennart Kindermann <lennart.kindermann@cloudseeds.de>
Signed-off-by: Lennart Kindermann <lennart.kindermann@cloudseeds.de>
Signed-off-by: Lennart Kindermann <lennart.kindermann@cloudseeds.de>
Signed-off-by: Lennart Kindermann <lennart.kindermann@cloudseeds.de>
alexec
reviewed
Nov 19, 2020
|
|
||
| // remove possible "*-" prefix | ||
| // e.g. crio-7a92a067289f6197148912be1c15f20f0330c7f3c541473d3b9c4043ca137b42.scope | ||
| parts := strings.Split(containerID, "-") |
There was a problem hiding this comment.
this could panic in len(parts) == 0?
There was a problem hiding this comment.
strings.Split() always returns a slice of length ≥ 1, as even the empty string, split on any "split char" would result in []string{""}.
Please refer to the documentation where it says:
If s does not contain sep and sep is not empty, Split returns a slice of length 1 whose only element is s.
There was a problem hiding this comment.
My bad - I actually meant line 435 - but I don't think it can panic on closer inspecting
alexec
approved these changes
Nov 19, 2020
|
Please sync with master. |
…s-cgroups Signed-off-by: Lennart Kindermann <lennart.kindermann@cloudseeds.de>
brabster
pushed a commit
to brabster/argo
that referenced
this pull request
Nov 24, 2020
Signed-off-by: Lennart Kindermann <lennart.kindermann@cloudseeds.de> Signed-off-by: Paul Brabban <paul.brabban@gmail.com>
alexcapras
pushed a commit
to alexcapras/argo
that referenced
this pull request
Dec 2, 2020
Signed-off-by: Lennart Kindermann <lennart.kindermann@cloudseeds.de> Signed-off-by: Alex Capras <alexcapras@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
In several environments, where docker is used and the kubelet and docker are managed by systemd, the cgroup line has a
docker-prefix. Here is a table of the possible combinations and the resulting cgroup lines.This PR fixes the behaviour and removes all possible "*-" prefixes, like "docker-*" in systemd controlled docker/kubelet environments.
Failing example before the fix: