Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(server): Support email for SSO+RBAC. Closes #4612 #4644

Merged
merged 7 commits into from
Dec 11, 2020
Merged

feat(server): Support email for SSO+RBAC. Closes #4612 #4644

merged 7 commits into from
Dec 11, 2020

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Dec 3, 2020 •
edited
Loading

Signed-off-by: Alex Collins alex_collins@intuit.com
Closes #4612

Checklist:

Screenshot 2020-12-03 at 12 46 08

@alexec
feat(server): Support email is SSO. Fixes argoproj#4612
a3498c1 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec alexec changed the title feat(server): Support email is SSO. Closes #4612 feat(server): Support email for SSO+RBAC. Closes #4612 Dec 3, 2020
@alexec
fix-4612: M manifests/quick-start/sso/overlays/argo-server-sa.yaml
a92fd64 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec alexec mentioned this pull request Dec 3, 2020
Closed
alexec added 2 commits December 3, 2020 15:12
@alexec
Merge branch 'master' into fix-4612
9b063fb 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec
fix-4612: M workflow/common/common.go
2343a6b 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec
Copy link
Contributor Author

alexec commented Dec 7, 2020

Testing by end user was successful.

@alexec alexec marked this pull request as ready for review December 7, 2020 23:32
@alexec alexec requested a review from jessesuen as a code owner December 7, 2020 23:32
@alexec
Copy link
Contributor Author

alexec commented Dec 7, 2020

@jessesuen can you please approve the very small + low risk proto changes?

@alexec alexec requested a review from simster7 December 8, 2020 20:39
@alexec alexec requested a review from sarabala1979 December 8, 2020 22:53
@alexec
Copy link
Contributor Author

alexec commented Dec 8, 2020

@simster7 @sarabala1979 this has been proto-approved by @jessesuen. Should be easy to review.

@jessesuen jessesuen removed their assignment Dec 9, 2020
@alexec
Copy link
Contributor Author

alexec commented Dec 11, 2020

@simster7 @sarabala1979 bump!

@alexec alexec merged commit 433dc5b into argoproj:master Dec 11, 2020
@alexec alexec deleted the fix-4612 branch December 11, 2020 20:12
@simster7 simster7 mentioned this pull request Dec 15, 2020
Closed
22 tasks
@covidium covidium mentioned this pull request Jan 25, 2021
Closed
@simster7 simster7 mentioned this pull request Jan 25, 2021
Closed
19 tasks
simster7 pushed a commit that referenced this pull request Jan 25, 2021
@alexec @simster7
feat(server): Support email for SSO+RBAC. Closes #4612 (#4644)
067b603 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@simster7
Copy link
Member

This is out on https://github.com/argoproj/argo/releases/tag/v2.12.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessesuen jessesuen jessesuen approved these changes

@simster7 simster7 Awaiting requested review from simster7

@sarabala1979 sarabala1979 Awaiting requested review from sarabala1979

Assignees
No one assigned
Labels
area/sso-rbac
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use Email for SSO RBAC with Google OIDC
4 participants
@alexec @simster7 @jessesuen @agilgur5