Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Mutex not being released on step completion #4847

Merged
merged 7 commits into from
Jan 19, 2021
Merged
Prev Previous commit
Next Next commit
Update operator_concurrency_test.go
sarabala1979 committed Jan 15, 2021
commit c9a08388b7c05c7303ab201a795e6df417d739f6
4 changes: 2 additions & 2 deletions workflow/controller/operator_concurrency_test.go
Original file line number Diff line number Diff line change
@@ -441,11 +441,11 @@ func TestSynchronizationWithRetry(t *testing.T) {
var cm v1.ConfigMap
err := yaml.Unmarshal([]byte(configMap), &cm)
assert.NoError(err)
_, err = controller.kubeclientset.CoreV1().ConfigMaps("default").Create(&cm)
_, err = controller.kubeclientset.CoreV1().ConfigMaps("default").Create(ctx, &cm, metav1.CreateOptions{})
assert.NoError(err)
t.Run("WorkflowWithRetry", func(t *testing.T) {
wf := unmarshalWF(RetryWfWithSemaphore)
wf, err := controller.wfclientset.ArgoprojV1alpha1().Workflows(wf.Namespace).Create(wf)
wf, err := controller.wfclientset.ArgoprojV1alpha1().Workflows(wf.Namespace).Create(ctx, wf, metav1.CreateOptions{})
assert.NoError(err)
woc := newWorkflowOperationCtx(wf, controller)
woc.operate(ctx)