fix(ui): UI bug fixes #4895
Merged
fix(ui): UI bug fixes #4895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
simster7
approved these changes
Jan 18, 2021
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
alexec
commented
Jan 18, 2021
| @@ -38,7 +38,7 @@ export const EventFlowPage = ({history, location, match}: RouteComponentProps<an | |||
| // state for URL and query parameters | |||
| const [namespace, setNamespace] = useState(match.params.namespace || ''); | |||
| const [showFlow, setShowFlow] = useState(queryParams.get('showFlow') === 'true'); | |||
| const [showWorkflows, setShowWorkflows] = useState(queryParams.get('showWorkflows') === 'true'); | |||
There was a problem hiding this comment.
default this low risk feature on
| @@ -2,9 +2,15 @@ import {GetUserInfoResponse, Info, Version} from '../../../models'; | |||
|
|
|||
| import requests from './requests'; | |||
|
|
|||
| let info: Promise<Info>; // we cache this globally rather than in localStorage so it is request once per page refresh | |||
There was a problem hiding this comment.
cache info in memory so we don't retrieve it repeatedly
| </button> | ||
| </div> | ||
| </Notice> | ||
| <textarea ref={hiddenText} style={{width: 0, height: 0, opacity: 0}} defaultValue={text} /> |
There was a problem hiding this comment.
remove a React warning
| @@ -47,7 +47,7 @@ export const WidgetGallery = ({namespace, name, label}: {namespace: string; name | |||
| </div> | |||
| <ul> | |||
| {parameters.map(p => ( | |||
| <li> | |||
| <li key={p.name}> | |||
There was a problem hiding this comment.
remove a React warning
| @@ -26,7 +26,7 @@ export const WorkflowCreator = ({namespace, onCreate}: {namespace: string; onCre | |||
| .list(namespace) | |||
| .then(setWorkflowTemplates) | |||
| .catch(setError); | |||
| }, []); | |||
| }, [namespace]); | |||
| @@ -195,7 +196,7 @@ export const WorkflowDetails = ({history, location, match}: RouteComponentProps< | |||
| ); | |||
| retryWatch.start(workflow.metadata.resourceVersion); | |||
| return () => retryWatch.stop(); | |||
| }, [workflow]); | |||
| }, [namespace, name]); | |||
There was a problem hiding this comment.
this was a pretty nasty bug, every time we got a changed workflow, we re-established the watch, resulting in a hot loop
| @@ -81,7 +81,8 @@ export const WorkflowDetails = ({history, location, match}: RouteComponentProps< | |||
| if (workflowOperation.title === 'DELETE') { | |||
| navigation.goto(uiUrl(`workflows/${workflow.metadata.namespace}`)); | |||
| } else { | |||
| navigation.goto(uiUrl(`workflows/${wf.metadata.namespace}/${wf.metadata.name}`)); | |||
| // navigation.goto does not seem to work here | |||
| document.location.href = uiUrl(`workflows/${wf.metadata.namespace}/${wf.metadata.name}`); | |||
There was a problem hiding this comment.
not sure why, not a big enough issue to properly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist: