build: Faster make start, faster smoke jobs
#4926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Collins <alex_collins@intuit.com>
alexec
commented
Jan 22, 2021
| @@ -51,6 +51,7 @@ CONTROLLER_IMAGE_FILE := dist/controller-image.marker | |||
| STATIC_BUILD ?= true | |||
| # should we build the static files? | |||
| STATIC_FILES ?= $(shell [ $(DEV_BRANCH) = true ] && echo false || echo true) | |||
| START_UI ?= $(shell [ "$(CI)" != "" ] && echo true || echo false) | |||
There was a problem hiding this comment.
we were building and running the UI for smoke/e2e tests on CI
| - ../../../../manifests/quick-start/mysql | ||
| - https://github.com/argoproj/argo-events/manifests/base/crds?ref=stable | ||
| - ../../../../manifests/quick-start/mysql | ||
| - https://raw.githubusercontent.com/argoproj/argo-events/stable/manifests/base/crds/argoproj.io_eventbus.yaml |
There was a problem hiding this comment.
missed this change in my last PR
| @@ -79,6 +79,9 @@ const config = { | |||
| historyApiFallback: { | |||
| disableDotRule: true | |||
| }, | |||
| watchOptions: { | |||
There was a problem hiding this comment.
this stops my fans from running 100%
| @@ -7,8 +7,11 @@ run: | |||
| skip-files: | |||
| - server/static/files.go | |||
| build-tags: | |||
| - e2e | |||
There was a problem hiding this comment.
split the e2e tests up by tag to make it easier to run groups of them by tag
simster7
approved these changes
Jan 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alex Collins alex_collins@intuit.com
Checklist: