-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: Faster make start
, faster smoke jobs
#4926
Conversation
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@@ -51,6 +51,7 @@ CONTROLLER_IMAGE_FILE := dist/controller-image.marker | |||
STATIC_BUILD ?= true | |||
# should we build the static files? | |||
STATIC_FILES ?= $(shell [ $(DEV_BRANCH) = true ] && echo false || echo true) | |||
START_UI ?= $(shell [ "$(CI)" != "" ] && echo true || echo false) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we were building and running the UI for smoke/e2e tests on CI
- ../../../../manifests/quick-start/mysql | ||
- https://github.com/argoproj/argo-events/manifests/base/crds?ref=stable | ||
- ../../../../manifests/quick-start/mysql | ||
- https://raw.githubusercontent.com/argoproj/argo-events/stable/manifests/base/crds/argoproj.io_eventbus.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missed this change in my last PR
@@ -79,6 +79,9 @@ const config = { | |||
historyApiFallback: { | |||
disableDotRule: true | |||
}, | |||
watchOptions: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this stops my fans from running 100%
@@ -7,8 +7,11 @@ run: | |||
skip-files: | |||
- server/static/files.go | |||
build-tags: | |||
- e2e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
split the e2e tests up by tag to make it easier to run groups of them by tag
Signed-off-by: Alex Collins alex_collins@intuit.com
Checklist: