Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support security token for OSS artifact driver #5491

Merged
merged 2 commits into from
Apr 6, 2021
Merged

feat: Support security token for OSS artifact driver #5491

merged 2 commits into from
Apr 6, 2021

Conversation

terrytangyuan
Copy link
Member

Signed-off-by: terrytangyuan terrytangyuan@gmail.com

Checklist:

Signed-off-by: terrytangyuan <terrytangyuan@gmail.com>
@codecov
Copy link

codecov bot commented Mar 23, 2021

Codecov Report

Merging #5491 (a7ec127) into master (be44ce9) will decrease coverage by 0.02%.
The diff coverage is 20.00%.

❗ Current head a7ec127 differs from pull request most recent head 757f9c0. Consider uploading reports for the commit 757f9c0 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5491      +/-   ##
==========================================
- Coverage   46.66%   46.63%   -0.03%     
==========================================
  Files         240      240              
  Lines       14985    14988       +3     
==========================================
- Hits         6993     6990       -3     
- Misses       7093     7096       +3     
- Partials      899      902       +3     
Impacted Files Coverage Δ
pkg/apis/workflow/v1alpha1/workflow_types.go 45.52% <ø> (ø)
workflow/artifacts/oss/oss.go 7.89% <0.00%> (-0.33%) ⬇️
workflow/controller/operator.go 70.25% <100.00%> (-0.28%) ⬇️
cmd/argo/commands/get.go 57.33% <0.00%> (+0.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be44ce9...757f9c0. Read the comment docs.

@alexec
Copy link
Contributor

alexec commented Mar 23, 2021

@jessesuen can we get approval to these proto changes?

Signed-off-by: terrytangyuan <terrytangyuan@gmail.com>
@terrytangyuan
Copy link
Member Author

Hi @jessesuen! In case you missed it among other notifications, could you review this simple proto change when you get a chance? Thanks!

@alexec alexec merged commit 4f3bbdc into argoproj:master Apr 6, 2021
@terrytangyuan terrytangyuan deleted the oss-security-token branch April 6, 2021 16:17
@simster7 simster7 mentioned this pull request Apr 19, 2021
50 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants