-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Document SSO expiry option #5552
Conversation
Merge from upstream
Signed-off-by: Tim Collins <tim@thecollins.team>
Codecov Report
@@ Coverage Diff @@
## master #5552 +/- ##
==========================================
+ Coverage 47.05% 47.10% +0.05%
==========================================
Files 240 240
Lines 15030 15030
==========================================
+ Hits 7072 7080 +8
+ Misses 7054 7051 -3
+ Partials 904 899 -5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Two minor comments
Signed-off-by: Tim Collins <tim@thecollins.team>
That said.. setting it to either "1" or "1h" doesn't boot me out after an hour.... |
Bug report? |
Make sure you restart the server after changing config. If you don’t get booted out, that’s a bug. |
I have definitely restarted it. Long weekend here in the uk now, but I'll continue to test on Tuesday before raising a bug. |
Signed-off-by: Tim Collins <tim@thecollins.team>
Checklist:
Fixes #5545 by documenting the sso expiry option.