feat(executor): Support accessing output parameters by PNS executor running as non-root #5564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5564 +/- ##
==========================================
+ Coverage 47.00% 47.08% +0.07%
==========================================
Files 240 240
Lines 15002 15002
==========================================
+ Hits 7052 7064 +12
+ Misses 7053 7039 -14
- Partials 897 899 +2
Continue to review full report at Codecov.
|
vladlosev
force-pushed
the
fix-enable-run-as-non-root
branch
from
970763f to
84b2fb9
Compare
vladlosev
changed the title
vladlosev
changed the title
vladlosev
force-pushed
the
fix-enable-run-as-non-root
branch
from
84b2fb9 to
9d98c38
Compare
vladlosev
changed the title
vladlosev
force-pushed
the
fix-enable-run-as-non-root
branch
from
9d98c38 to
b506435
Compare
vladlosev
force-pushed
the
fix-enable-run-as-non-root
branch
3 times, most recently
from
4d3d2e1 to
b6cc892
Compare
Signed-off-by: Vlad Losev <vladimir.losev@sage.com>
Signed-off-by: Vlad Losev <vladimir.losev@sage.com>
Signed-off-by: Vlad Losev <vladimir.losev@sage.com>
Signed-off-by: Vlad Losev <vladimir.losev@sage.com>
Signed-off-by: Vlad Losev <vladimir.losev@sage.com>
Signed-off-by: Vlad Losev <vladimir.losev@sage.com>
Signed-off-by: Vlad Losev <vladimir.losev@sage.com>
Signed-off-by: Vlad Losev <vladimir.losev@sage.com>
Signed-off-by: Vlad Losev <vladimir.losev@sage.com>
Signed-off-by: Vlad Losev <vladimir.losev@sage.com>
Signed-off-by: Vlad Losev <vladimir.losev@sage.com>
Signed-off-by: Vlad Losev <vladimir.losev@sage.com>
Signed-off-by: Vlad Losev <vladimir.losev@sage.com>
Signed-off-by: Vlad Losev <vladimir.losev@sage.com>
Signed-off-by: Vlad Losev <vladimir.losev@sage.com>
Signed-off-by: Vlad Losev <vladimir.losev@sage.com>
Signed-off-by: Vlad Losev <vladimir.losev@sage.com>
Signed-off-by: Vlad Losev <vladimir.losev@sage.com>
Signed-off-by: Vlad Losev <vladimir.losev@sage.com>
Signed-off-by: Vlad Losev <vladimir.losev@sage.com>
Signed-off-by: Vlad Losev <vladimir.losev@sage.com>
vladlosev
force-pushed
the
fix-enable-run-as-non-root
branch
from
b6cc892 to
7a05cca
Compare
Signed-off-by: Vlad Losev <vladimir.losev@sage.com>
alexec
changed the title
alexec
reviewed
Apr 5, 2021
| @@ -23,6 +23,15 @@ func (s *RunAsNonRootSuite) TestRunAsNonRootWorkflow() { | |||
| WaitForWorkflow(fixtures.ToBeSucceeded) | |||
| } | |||
|
|
|||
| func (s *RunAsNonRootSuite) TestRunAsNonRootWithOutputParams() { | |||
| s.Need(fixtures.None(fixtures.Docker, fixtures.K8SAPI, fixtures.Kubelet)) | |||
There was a problem hiding this comment.
minor - do you want to include emissary in your test? instead maybe just
s.Need(fixtures.PNS)
There was a problem hiding this comment.
The test passes under emissary, and it is a valid use case (I can attest to that!) so I think we want to keep it for emissary to ensure there are no regressions in the future. That is unless you have reasons to explicitly not support this use case for emissary. Please let me know if that's the case and I will drop it for emissary.
| @@ -0,0 +1,25 @@ | |||
| apiVersion: argoproj.io/v1alpha1 | |||
There was a problem hiding this comment.
please append -pipeline.yaml to name
Signed-off-by: Vlad Losev <vladimir.losev@sage.com>
alexec
approved these changes
Apr 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Argo PNS executor requires the SYS_CHROOT and the SYS_PTRACE capabilities for access to the workflow output parameters when they are saved inside the image. When it is run as a root, those capabilities are available to it immediately because they are added by the workflow controller to the container's security context. But when it's run as a non-root user, the capabilities are available in the process's inherited capability set but neither in its effective nor permitted sets. Thus, a chroot attempt in such mode currently fails. This PR adds the requisite capability bits to the
argoexecbinary in the container, which allows the executor process to gain these capabilities when launched, and use those syscalls successfully.Checklist: