fix(controller): clean up before insert into argo_archived_workflows_labels

[book987]

fix #5567

Checklist:

• My organization is added to USERS.md.

[codecov]

Codecov Report

Merging #5568 (a276945) into master (2b3655e) will increase coverage by 0.09%.
The diff coverage is 0.00%.

❗ Current head a276945 differs from pull request most recent head 5db8b77. Consider uploading reports for the commit 5db8b77 to get more accurate results

@@            Coverage Diff             @@
##           master    #5568      +/-   ##
==========================================
+ Coverage   46.94%   47.04%   +0.09%     
==========================================
  Files         240      240              
  Lines       15016    15002      -14     
==========================================
+ Hits         7050     7057       +7     
+ Misses       7070     7046      -24     
- Partials      896      899       +3     

Impacted Files	Coverage Δ
persist/sqldb/workflow_archive.go	0.00% <0.00%> (ø)
workflow/controller/operator.go	70.69% <0.00%> (-0.28%)	⬇️
pkg/apiclient/http1/event-watch-client.go	0.00% <0.00%> (ø)
...kg/apiclient/http1/cron-workflow-service-client.go	0.00% <0.00%> (ø)
...piclient/argo-kube-cron-workflow-service-client.go	0.00% <0.00%> (ø)
...lient/error-translating-workflow-service-client.go	0.00% <0.00%> (ø)
...ient/argo-kube-workflow-template-service-client.go	0.00% <0.00%> (ø)
.../error-translating-cron-workflow-service-client.go	0.00% <0.00%> (ø)
...o-kube-cluster-workflow-template-service-client.go	0.00% <0.00%> (ø)
cmd/argo/commands/get.go	56.66% <0.00%> (+0.66%)	⬆️
... and 3 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b3655e...5db8b77. Read the comment docs.

[alexec]

This should not be needed. There should be cascade delete when record is deleted.

[alexec]

after some spinning around - I realise this is the correct solution

[alexec]

Needs to be back-port to v2.12 and v3.0

[alexec]

#5551