Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Generate self-signed certs with SAN #5571

Closed
wants to merge 3 commits into from

Conversation

simster7
Copy link
Member

@simster7 simster7 commented Apr 1, 2021

Signed-off-by: Simon Behar <simbeh7@gmail.com>
@codecov
Copy link

codecov bot commented Apr 1, 2021

Codecov Report

Merging #5571 (32ed5a3) into master (2b3655e) will increase coverage by 0.13%.
The diff coverage is n/a.

❗ Current head 32ed5a3 differs from pull request most recent head 93dbda9. Consider uploading reports for the commit 93dbda9 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5571      +/-   ##
==========================================
+ Coverage   46.94%   47.08%   +0.13%     
==========================================
  Files         240      240              
  Lines       15016    14995      -21     
==========================================
+ Hits         7050     7060      +10     
+ Misses       7070     7037      -33     
- Partials      896      898       +2     
Impacted Files Coverage Δ
pkg/apiclient/http1/event-watch-client.go 0.00% <0.00%> (ø)
...kg/apiclient/http1/cron-workflow-service-client.go 0.00% <0.00%> (ø)
...piclient/argo-kube-cron-workflow-service-client.go 0.00% <0.00%> (ø)
...lient/error-translating-workflow-service-client.go 0.00% <0.00%> (ø)
...ient/argo-kube-workflow-template-service-client.go 0.00% <0.00%> (ø)
.../error-translating-cron-workflow-service-client.go 0.00% <0.00%> (ø)
...o-kube-cluster-workflow-template-service-client.go 0.00% <0.00%> (ø)
cmd/argoexec/commands/emissary.go 50.00% <0.00%> (+1.56%) ⬆️
server/workflow/workflow_server.go 42.73% <0.00%> (+2.27%) ⬆️
pkg/apiclient/apiclient.go 14.28% <0.00%> (+8.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b3655e...93dbda9. Read the comment docs.

@alexec
Copy link
Contributor

alexec commented Apr 1, 2021

Do we need this now with my fix?

@simster7
Copy link
Member Author

simster7 commented Apr 1, 2021

Do we need this now with my fix?

I believe so, I will explain once I gather more information

@simster7
Copy link
Member Author

simster7 commented Apr 1, 2021

Not needed

@simster7 simster7 closed this Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants