fix(artifacts): only retry on transient S3 errors

[dinever]

Closes #5220

Hi,

This PR fixes the issue of executor retrying non-transient S3 errors.

I took the list of retryable errors from the minio-go repo.

As of today, this package doesn't have any unit tests. As the logic is getting more complex it's kind of risky to have no tests. I'll see if I can add some. (Might need some minor refactoring)

Thanks!

[codecov]

Codecov Report

Merging #5579 (c40a2d0) into master (54f4c26) will increase coverage by 0.03%.
The diff coverage is 76.19%.

❗ Current head c40a2d0 differs from pull request most recent head 513a4b5. Consider uploading reports for the commit 513a4b5 to get more accurate results

@@            Coverage Diff             @@
##           master    #5579      +/-   ##
==========================================
+ Coverage   47.08%   47.12%   +0.03%     
==========================================
  Files         240      242       +2     
  Lines       15050    15137      +87     
==========================================
+ Hits         7087     7133      +46     
- Misses       7059     7098      +39     
- Partials      904      906       +2     

Impacted Files	Coverage Δ
cmd/argoexec/commands/root.go	1.72% <0.00%> (+0.02%)	⬆️
workflow/artifacts/s3/errors.go	60.00% <60.00%> (ø)
workflow/artifacts/s3/s3.go	41.66% <70.73%> (ø)
workflow/controller/operator.go	71.11% <100.00%> (+0.17%)	⬆️
workflow/metrics/server.go	12.50% <0.00%> (-4.17%)	⬇️
cmd/argo/commands/get.go	56.95% <0.00%> (+0.64%)	⬆️
cmd/argoexec/commands/emissary.go	50.00% <0.00%> (+1.56%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54f4c26...513a4b5. Read the comment docs.

[dinever]

Will rebase after #5601

[alexec]

I request one final small change. Once you've done that - dismiss this review so I get notified.