fix(controller): Consider nested expanded task in reference #5594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simon Behar <simbeh7@gmail.com>
alexec
changed the title
alexec
reviewed
Apr 5, 2021
| @@ -2360,7 +2360,10 @@ func hasOutputResultRef(name string, parentTmpl *wfv1.Template) bool { | |||
| func getStepOrDAGTaskName(nodeName string) string { | |||
| // If our name contains an open parenthesis, this node is a child of a Retry node or an expanded node | |||
| // (e.g. withItems, withParams, etc.). Ignore anything after the parenthesis. | |||
| if parenthesisIndex := strings.Index(nodeName, "("); parenthesisIndex >= 0 { | |||
| if parenthesisIndex := strings.LastIndex(nodeName, "("); parenthesisIndex >= 0 { | |||
alexec
approved these changes
Apr 5, 2021
Codecov Report
@@ Coverage Diff @@
## master #5594 +/- ##
==========================================
+ Coverage 47.00% 47.08% +0.07%
==========================================
Files 240 240
Lines 15002 15005 +3
==========================================
+ Hits 7052 7065 +13
+ Misses 7053 7042 -11
- Partials 897 898 +1
Continue to review full report at Codecov.
|
simster7
added a commit
that referenced
this pull request
Apr 19, 2021
Signed-off-by: Simon Behar <simbeh7@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5574