fix(ui): Fix editor. Fixes #5613 Fixes #5617 #5620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Codecov Report
@@ Coverage Diff @@
## master #5620 +/- ##
==========================================
+ Coverage 47.05% 47.10% +0.05%
==========================================
Files 240 240
Lines 15030 15034 +4
==========================================
+ Hits 7072 7082 +10
+ Misses 7054 7052 -2
+ Partials 904 900 -4
Continue to review full report at Codecov.
|
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
alexec
changed the title
alexec
commented
Apr 8, 2021
| - - name: process-artifact | ||
| template: process-message | ||
| withParam: "{{steps.generate-artifact.outputs.result}}" | ||
| - - name: list-log-files |
There was a problem hiding this comment.
@simster7 I wanted an example for CNCF webinar and could not use the example.
alexec
commented
Apr 8, 2021
.github/workflows/ci-build.yaml
Outdated
| @@ -97,6 +97,7 @@ jobs: | |||
| echo "- name: fake_token_user" >> ~/.kube/config | |||
| echo " user:" >> ~/.kube/config | |||
| echo " token: xxxxxx" >> ~/.kube/config | |||
| until kubectl cluster-info ; do sleep 10s ; done | |||
There was a problem hiding this comment.
hopefully fix some flakey builds
simster7
approved these changes
Apr 8, 2021
Comment on lines
+30
to
+34
| // we ONLY want to change the text, if the normalized version has changed, this prevents white-space changes | ||
| // from resulting in a significant change | ||
| if (text !== stringify(parse(editor.current.editor.getValue()), lang)) { | ||
| editor.current.editor.setValue(text); | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5613
Fixes #5617