fix: git clone on non-default branch fails (Fixes #5629)

[kennytrytek]

• Fixes Issue 5629.

Signed-off-by: Kenny Trytek kenneth.g.trytek@gmail.com

Checklist:

• My organization is added to USERS.md.

[codecov]

Codecov Report

Merging #5630 (86641a6) into master (46ec302) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

❗ Current head 86641a6 differs from pull request most recent head f24f932. Consider uploading reports for the commit f24f932 to get more accurate results

@@            Coverage Diff             @@
##           master    #5630      +/-   ##
==========================================
- Coverage   47.17%   47.12%   -0.05%     
==========================================
  Files         240      240              
  Lines       15060    15062       +2     
==========================================
- Hits         7104     7098       -6     
- Misses       7053     7059       +6     
- Partials      903      905       +2     

Impacted Files	Coverage Δ
workflow/artifacts/git/git.go	41.48% <100.00%> (+1.27%)	⬆️
cmd/argo/commands/get.go	55.66% <0.00%> (-1.95%)	⬇️
cmd/argoexec/commands/emissary.go	48.43% <0.00%> (-1.57%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46ec302...f24f932. Read the comment docs.

[kennytrytek]

I don't think this change should cause catastrophic failure of the tests. Closing/reopening to try again...

[alexec]

Can you please add a test?

[alexec]

.

[kennytrytek]

@alexec:
Can you please add a test?

Added test to verify the revision used is in the expected format. A full e2e test seemed a bit heavy for this change.

[kennytrytek]

Rebased onto latest master. No merge conflicts.

[alexec]

Please fix lint.

[kennytrytek]

Sorry, didn't realize there was a lint target locally; I'll be sure to do that before pushing for future changes.

[alexec]

Test unrelated to changes failed:

--- FAIL: TestDAGTemplateParallelismLimit (0.11s)
    operator_test.go:1519: 
        	Error Trace:	operator_test.go:1519
        	Error:      	Not equal: 
        	            	expected: 2
        	            	actual  : 4
        	Test:       	TestDAGTemplateParallelismLimit

Re-running build.