Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): support any yaml reference in link #5667

Merged
merged 3 commits into from
Apr 14, 2021

Conversation

tczhao
Copy link
Member

@tczhao tczhao commented Apr 13, 2021

Resolves #4752

Signed-off-by: Tianchu Zhao evantczhao@gmail.com

Checklist:

@tczhao tczhao requested a review from jessesuen as a code owner April 13, 2021 07:54
@codecov
Copy link

codecov bot commented Apr 13, 2021

Codecov Report

Merging #5667 (f5a5b19) into master (54f4c26) will increase coverage by 0.03%.
The diff coverage is 68.42%.

❗ Current head f5a5b19 differs from pull request most recent head 095bd40. Consider uploading reports for the commit 095bd40 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5667      +/-   ##
==========================================
+ Coverage   47.08%   47.12%   +0.03%     
==========================================
  Files         240      242       +2     
  Lines       15050    15135      +85     
==========================================
+ Hits         7087     7132      +45     
- Misses       7059     7095      +36     
- Partials      904      908       +4     
Impacted Files Coverage Δ
cmd/argo/commands/client/conn.go 13.33% <0.00%> (ø)
cmd/argoexec/commands/root.go 1.72% <0.00%> (+0.02%) ⬆️
cmd/argoexec/commands/wait.go 0.00% <0.00%> (ø)
workflow/executor/executor.go 16.23% <0.00%> (-0.08%) ⬇️
workflow/artifacts/s3/errors.go 60.00% <60.00%> (ø)
workflow/artifacts/s3/s3.go 41.66% <70.73%> (ø)
workflow/artifacts/git/git.go 41.48% <100.00%> (+1.27%) ⬆️
workflow/controller/operator.go 70.84% <100.00%> (-0.10%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54f4c26...095bd40. Read the comment docs.

Signed-off-by: Tianchu Zhao <evantczhao@gmail.com>
Copy link
Contributor

@alexec alexec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks really good so far - one change suggested - dismiss this review when ready to review again

ui/src/app/shared/components/links.tsx Show resolved Hide resolved
pkg/apis/workflow/v1alpha1/info.go Outdated Show resolved Hide resolved
Signed-off-by: Tianchu Zhao <evantczhao@gmail.com>
Signed-off-by: Tianchu Zhao <evantczhao@gmail.com>
@alexec alexec merged commit 71dfc79 into argoproj:master Apr 14, 2021
@simster7 simster7 mentioned this pull request Apr 19, 2021
50 tasks
@zewelor
Copy link

zewelor commented May 25, 2021

Is there any example how to use this ?

@tczhao
Copy link
Member Author

tczhao commented May 25, 2021

@zewelor
Hi, you can modify the links in configmap
using something like workflow.metadata.annotations.userDefinedKey
the userDefinedKey is from your workflow

note that this feature is only available from master branch at the moment or future 3.1 release

@zewelor
Copy link

zewelor commented May 25, 2021

Got it thanks for reply !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support external link annotation
3 participants