fix(executor):Failure node failed to get archived log #5671
Conversation
uucloud
force-pushed
the
fix/archive_log
branch
from
6495066
to
ac48311
Compare
uucloud
changed the title
uucloud
changed the title
Codecov Report
@@ Coverage Diff @@
## master #5671 +/- ##
==========================================
+ Coverage 47.05% 47.15% +0.09%
==========================================
Files 240 240
Lines 15049 15056 +7
==========================================
+ Hits 7082 7099 +17
+ Misses 7062 7052 -10
Partials 905 905
Continue to review full report at Codecov.
|
uucloud
force-pushed
the
fix/archive_log
branch
from
ac48311
to
01c8ba3
Compare
Signed-off-by: uucloud <uucloud@qq.com>
uucloud
force-pushed
the
fix/archive_log
branch
from
01c8ba3
to
0811cbf
Compare
cmd/argoexec/commands/wait.go
Outdated
| @@ -60,12 +60,14 @@ func waitContainer(ctx context.Context) error { | |||
| // Saving output parameters | |||
| err = wfExecutor.SaveParameters(ctx) | |||
| if err != nil { | |||
| wfExecutor.AnnotateOutputs(ctx, logArt) | |||
There was a problem hiding this comment.
I think we need a slightly different approach here.
In each error branch of this func, we exit. Instead, we should just add wfExecutor.AddError. We do not need to exit until the end of the func, where we can exit with an error if there we any errors.
There was a problem hiding this comment.
I modified the code until the func was executed to the end, and then checked for errors and exited, but I'm not sure if KillSidecars error should be checked as well?
Signed-off-by: uucloud <uucloud@qq.com>
Checklist:
close #5669