Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make task/step name extractor robust #5672

Merged
merged 2 commits into from
Apr 13, 2021
Merged

Conversation

simster7
Copy link
Member

@simster7 simster7 commented Apr 13, 2021

Fixes #5600

Signed-off-by: Simon Behar <simbeh7@gmail.com>
Signed-off-by: Simon Behar <simbeh7@gmail.com>
@codecov
Copy link

codecov bot commented Apr 13, 2021

Codecov Report

Merging #5672 (6b599fd) into master (ded95bc) will increase coverage by 0.07%.
The diff coverage is 100.00%.

❗ Current head 6b599fd differs from pull request most recent head d520ea1. Consider uploading reports for the commit d520ea1 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5672      +/-   ##
==========================================
+ Coverage   47.05%   47.13%   +0.07%     
==========================================
  Files         240      240              
  Lines       15049    15060      +11     
==========================================
+ Hits         7082     7098      +16     
+ Misses       7062     7057       -5     
  Partials      905      905              
Impacted Files Coverage Δ
workflow/controller/operator.go 71.11% <100.00%> (+0.44%) ⬆️
cmd/argoexec/commands/emissary.go 48.43% <0.00%> (-1.57%) ⬇️
cmd/argo/commands/get.go 56.95% <0.00%> (+0.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ded95bc...d520ea1. Read the comment docs.

@simster7 simster7 merged commit 46ec302 into argoproj:master Apr 13, 2021
@simster7 simster7 mentioned this pull request Apr 19, 2021
50 tasks
simster7 added a commit that referenced this pull request Apr 19, 2021
Signed-off-by: Simon Behar <simbeh7@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to resolve outputs.result variable
3 participants