-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(executor): Correctly surface error when resource is deleted during status checking #5675
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5675 +/- ##
==========================================
+ Coverage 47.07% 47.15% +0.07%
==========================================
Files 242 242
Lines 15135 15136 +1
==========================================
+ Hits 7125 7137 +12
+ Misses 7105 7093 -12
- Partials 905 906 +1
Continue to review full report at Codecov.
|
Codegen failed since |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix codegen
…g status checking Signed-off-by: terrytangyuan <terrytangyuan@gmail.com>
Signed-off-by: terrytangyuan <terrytangyuan@gmail.com>
@alexec It was a timeout/connection issue when installing kustomize on GitHub Actions. Re-running fixed it. |
In the current implementation,
strings.Contains(jsonString, "NotFound")
block would never be reached since the error would be returned immediately if it's not transient. Also switched to useapierr.IsNotFound(err)
which is more robust than string matching.Signed-off-by: terrytangyuan terrytangyuan@gmail.com
Checklist: