Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Increase Name width to 3 and decrease NameSpace width to 1 #5678

Merged
merged 3 commits into from
Apr 14, 2021

Conversation

pruthvichow
Copy link
Contributor

@pruthvichow pruthvichow commented Apr 14, 2021

fix(ui): Increase Name field width on Argo UI

On Argo UI If the workflow name is big(25-30 char) it is getting truncated and there no hover option too.
Idea is to increase NameField Width to 3 and decrease the NameSpace field to 1.

Screen Shot 2021-04-14 at 12 54 57 PM

Checklist:

@codecov
Copy link

codecov bot commented Apr 14, 2021

Codecov Report

Merging #5678 (b7126f4) into master (71dfc79) will decrease coverage by 0.03%.
The diff coverage is n/a.

❗ Current head b7126f4 differs from pull request most recent head 128ee9b. Consider uploading reports for the commit 128ee9b to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5678      +/-   ##
==========================================
- Coverage   47.12%   47.09%   -0.04%     
==========================================
  Files         242      242              
  Lines       15135    15135              
==========================================
- Hits         7133     7128       -5     
- Misses       7095     7098       +3     
- Partials      907      909       +2     
Impacted Files Coverage Δ
workflow/controller/operator.go 70.84% <0.00%> (-0.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71dfc79...128ee9b. Read the comment docs.

@alexec
Copy link
Contributor

alexec commented Apr 14, 2021

Please add a screenshot, signoff commits + update PR title to be semantic.

Signed-off-by: pruthvichow <pruthvi.papasani@gmail.com>
@pruthvichow pruthvichow force-pushed the ui-increaseNameFieldWidth branch from 0c47e99 to ed82472 Compare April 14, 2021 20:39
@pruthvichow pruthvichow changed the title Increase Name width to 3 and decrease NameSpace width to 1 fix(ui): Increase Name width to 3 and decrease NameSpace width to 1 Apr 14, 2021
@pruthvichow pruthvichow changed the title fix(ui): Increase Name width to 3 and decrease NameSpace width to 1 fix: Increase Name width to 3 and decrease NameSpace width to 1 Apr 14, 2021
@pruthvichow pruthvichow force-pushed the ui-increaseNameFieldWidth branch 2 times, most recently from 21e8616 to a4d05fc Compare April 14, 2021 21:13
Signed-off-by: pruthvichow <pruthvi.papasani@gmail.com>
Signed-off-by: pruthvichow <pruthvi.papasani@gmail.com>
@pruthvichow pruthvichow force-pushed the ui-increaseNameFieldWidth branch from a4d05fc to 128ee9b Compare April 14, 2021 21:22
@pruthvichow
Copy link
Contributor Author

Please add a screenshot, signoff commits + update PR title to be semantic.

@alexec Made necessary changes. Build is passing now. I'm still unable to add reviewers.

@alexec alexec merged commit bf5d7bf into argoproj:master Apr 14, 2021
@simster7 simster7 mentioned this pull request Apr 19, 2021
50 tasks
@ppapasani1-rms ppapasani1-rms mentioned this pull request May 7, 2021
33 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants