Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Specify Dockerfile version #5689

Merged
merged 1 commit into from
Apr 16, 2021
Merged

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Apr 16, 2021

Needed for the mount option on some build system (e.g. ours).

Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec alexec linked an issue Apr 16, 2021 that may be closed by this pull request
@alexec alexec requested a review from whynowy April 16, 2021 16:41
@codecov
Copy link

codecov bot commented Apr 16, 2021

Codecov Report

Merging #5689 (8aeeffd) into master (e3d1d1e) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5689      +/-   ##
==========================================
+ Coverage   46.86%   46.89%   +0.03%     
==========================================
  Files         244      244              
  Lines       15209    15209              
==========================================
+ Hits         7127     7132       +5     
+ Misses       7172     7171       -1     
+ Partials      910      906       -4     
Impacted Files Coverage Δ
cmd/argo/commands/get.go 56.31% <0.00%> (-0.65%) ⬇️
workflow/controller/operator.go 71.11% <0.00%> (+0.26%) ⬆️
cmd/argoexec/commands/emissary.go 50.00% <0.00%> (+1.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3d1d1e...8aeeffd. Read the comment docs.

@alexec alexec marked this pull request as ready for review April 16, 2021 17:37
@alexec alexec added this to the v3.0 milestone Apr 16, 2021
@alexec alexec merged commit 5a39722 into argoproj:master Apr 16, 2021
@alexec alexec deleted the dockerfile branch April 16, 2021 17:37
@simster7 simster7 mentioned this pull request Apr 19, 2021
50 tasks
simster7 pushed a commit that referenced this pull request Apr 19, 2021
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update Dockerfile to be have 1.2 syntax header
2 participants