Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(executor): Ignore not existing metadata. Fixes #5656 #5695

Merged
merged 3 commits into from
Apr 19, 2021

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Apr 17, 2021

No description provided.

alexec added 2 commits April 17, 2021 15:22
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec alexec added this to the v3.0 milestone Apr 17, 2021
@alexec alexec linked an issue Apr 17, 2021 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Apr 17, 2021

Codecov Report

Merging #5695 (20bb58b) into master (91c08cd) will decrease coverage by 0.08%.
The diff coverage is 0.00%.

❗ Current head 20bb58b differs from pull request most recent head e29c468. Consider uploading reports for the commit e29c468 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5695      +/-   ##
==========================================
- Coverage   46.91%   46.82%   -0.09%     
==========================================
  Files         244      244              
  Lines       15209    15211       +2     
==========================================
- Hits         7135     7123      -12     
- Misses       7169     7182      +13     
- Partials      905      906       +1     
Impacted Files Coverage Δ
workflow/executor/executor.go 16.18% <0.00%> (-0.06%) ⬇️
server/workflow/workflow_server.go 40.45% <0.00%> (-2.28%) ⬇️
cmd/argoexec/commands/emissary.go 48.43% <0.00%> (-1.57%) ⬇️
workflow/controller/operator.go 70.84% <0.00%> (-0.22%) ⬇️
cmd/argo/commands/get.go 56.95% <0.00%> (+0.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91c08cd...e29c468. Read the comment docs.

@alexec alexec marked this pull request as ready for review April 18, 2021 01:10
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec alexec merged commit 9a872de into argoproj:master Apr 19, 2021
@alexec alexec deleted the not-exists branch April 19, 2021 15:45
@simster7 simster7 mentioned this pull request Apr 19, 2021
50 tasks
@henrywangx
Copy link
Contributor

@alexec Hi alex,should this fix be cherry-picked into v2.12?We also face this issue with v2.12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

stat /argo/podmetadata/annotations: no such file or directory
4 participants