Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support to auto-mount service account tokens for plugins. #8176

Merged
merged 4 commits into from
Mar 22, 2022

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Mar 17, 2022

Signed-off-by: Alex Collins alex_collins@intuit.com

Users have requested a couple of times the ability to access the Kuberenetes API. This uses the same pattern as PodSpec.AutomountServiceAccountToken, but the name of the service account is fixed.

Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec alexec marked this pull request as ready for review March 17, 2022 18:30
@alexec alexec enabled auto-merge (squash) March 17, 2022 18:30
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
Copy link
Member

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'd recommend adding some docs: 1) why/how to use this and 2) "please please please only do this if necessary and then limit permissions carefully".

@alexec alexec linked an issue Mar 20, 2022 that may be closed by this pull request
@whybeyoung
Copy link
Contributor

will this be merged at v3.3.2?

@sarabala1979 sarabala1979 self-assigned this Mar 21, 2022
@alexec alexec merged commit d33d391 into argoproj:master Mar 22, 2022
@alexec alexec deleted the token branch March 22, 2022 15:22
dpadhiar pushed a commit to dpadhiar/argo-workflows that referenced this pull request Mar 23, 2022
@sarabala1979 sarabala1979 mentioned this pull request Apr 14, 2022
85 tasks
@whybeyoung
Copy link
Contributor

whybeyoung commented Apr 27, 2022

why this feature note picked in v3.3.2 or 3.3.3 waiting for long times. because my volcano plugin rely on it. @sarabala1979

whybeyoung pushed a commit to whybeyoung/argo-workflows that referenced this pull request Apr 27, 2022
alexec added a commit that referenced this pull request Apr 27, 2022
…8176)

Signed-off-by: Alex Collins <alex_collins@intuit.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugin service account RBAC support
5 participants