feat: Add a link in the UI for WorkflowTemplate. Fixes #4760 #8208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shubham Nazare <shubham4443@gmail.com>
Signed-off-by: Shubham Nazare <shubham4443@gmail.com>
|
I can't figure out why the tests are failing. Can anybody please help me? |
|
Run “yarn lint” |
Signed-off-by: Shubham Nazare <shubham4443@gmail.com>
alexec
reviewed
Mar 27, 2022
ui/src/app/cron-workflows/components/cron-workflow-details/cron-workflow-details.tsx
Show resolved
Hide resolved
alexec
reviewed
Mar 27, 2022
| const url: string = clusterScope ? `/cluster-workflow-templates/${templateName}` : `/workflow-templates/${cronWorkflow.metadata.namespace}/${templateName}`; | ||
|
|
||
| const templateLink: Link = { | ||
| name: 'Workflow Template Link', |
There was a problem hiding this comment.
Please change to “Open Workflow Template” and use the same icon as left-hand-nav does.
alexec
reviewed
Mar 27, 2022
| const url: string = clusterScope ? `/cluster-workflow-templates/${templateName}` : `/workflow-templates/${workflow.metadata.namespace}/${templateName}`; | ||
|
|
||
| const templateLink: Link = { | ||
| name: 'Workflow Template Link', |
There was a problem hiding this comment.
Please change to “Open Workflow Template” and use the same icon as left-hand-nav does.
Signed-off-by: Shubham Nazare <shubham4443@gmail.com>
|
thank you for changes - please can I ask you attach updated screenshots? this shows it works |
|
For WorkflowTemplate kind -
For ClusterWorkflowTemplate kind -
I've updated the first comment's screenshot as well. |
alexec
approved these changes
Mar 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shubham Nazare shubham4443@gmail.com
Fixes #4760
If a Workflow or CronWorkflow uses a WorkflowTemplate or ClusterWorkflowTemplate as workflowTemplateRef, a link is provided to redirect to that template.
For WorkflowTemplate kind -
For ClusterWorkflowTemplate kind -