fix: Remove path traversal CWE-23 #8331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Collins <alex_collins@intuit.com>
| @@ -832,7 +836,7 @@ func untar(tarPath string, destPath string) error { | |||
| case header == nil: | |||
| continue | |||
| } | |||
| target := filepath.Join(dest, header.Name) | |||
| target := filepath.Join(dest, filepath.Clean(header.Name)) | |||
There was a problem hiding this comment.
This should be clean instead of filepath.clean
There was a problem hiding this comment.
I accidentally pushed the clean func, I've reverted.
I wanted understand how Clean worked with values such as ../../foo
terrytangyuan
approved these changes
Apr 7, 2022
| @@ -832,7 +836,7 @@ func untar(tarPath string, destPath string) error { | |||
| case header == nil: | |||
| continue | |||
| } | |||
| target := filepath.Join(dest, header.Name) | |||
| target := filepath.Join(dest, filepath.Clean(header.Name)) | |||
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alex Collins alex_collins@intuit.com
https://app.snyk.io/org/argoproj/project/e917d104-c0c4-477b-853c-9d1451b6f803
You can test these fixes locally: