fix: Daemon step updated 'pod delete' while pod is running #8399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Saravanan Balasubramanian <sarabala1979@gmail.com>
Signed-off-by: Saravanan Balasubramanian <sarabala1979@gmail.com>
Signed-off-by: Saravanan Balasubramanian <sarabala1979@gmail.com>
alexec
reviewed
Apr 14, 2022
| @@ -18,7 +18,7 @@ func (woc *wfOperationCtx) queuePodsForCleanup() { | |||
| for _, obj := range objs { | |||
| pod := obj.(*apiv1.Pod) | |||
| nodeID := woc.nodeID(pod) | |||
| if !woc.execWf.Status.Nodes[nodeID].Fulfilled() { | |||
| if !woc.execWf.Status.Nodes[nodeID].Phase.Fulfilled() { | |||
There was a problem hiding this comment.
Fulfilled will take care skipped and Omitted nodes also. Fulfilled is right one
// Fulfilled returns whether a phase is fulfilled, i.e. it completed execution or was skipped or omitted
func (phase NodePhase) Fulfilled() bool {
return phase.Completed() || phase == NodeSkipped || phase == NodeOmitted
}There was a problem hiding this comment.
strange they are inconsistent
Signed-off-by: Saravanan Balasubramanian <sarabala1979@gmail.com>
sarabala1979
changed the title
|
@alexec can you review this PR? once it is approved and merged I will start v3.3.2 |
alexec
approved these changes
Apr 14, 2022
sarabala1979
added a commit
that referenced
this pull request
Apr 18, 2022
* fix: Updating complated node status Signed-off-by: Saravanan Balasubramanian <sarabala1979@gmail.com> * fix: Daemon step updated 'pod delete' while pod is running Signed-off-by: Saravanan Balasubramanian <sarabala1979@gmail.com> * fix: update Signed-off-by: Saravanan Balasubramanian <sarabala1979@gmail.com> * fix: e2e Signed-off-by: Saravanan Balasubramanian <sarabala1979@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #TODO