fix: add nil check for retryStrategy.Limit in deadline check. Fixes #8990 #8991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rgoproj#8990 Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>
terrytangyuan
approved these changes
Jun 18, 2022
sarabala1979
pushed a commit
that referenced
this pull request
Jun 20, 2022
juliev0
pushed a commit
to juliev0/argo-workflows
that referenced
this pull request
Jul 14, 2022
…rgoproj#8990 (argoproj#8991) Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com> Signed-off-by: Julie Vogelman <julie_vogelman@intuit.com>
agilgur5
added
area/controller
agilgur5
added
area/retryStrategy
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dillen Padhiar dillen_padhiar@intuit.com
Fixes #8990