Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat 'connection reset by peer' as a transient network error. Fixes #9013 #9017

Merged
merged 1 commit into from
Jun 21, 2022

Conversation

mtougeron
Copy link
Contributor

Fixes #9013

This treats connection reset by peer network errors as transient so that they can be retried.

@mtougeron mtougeron marked this pull request as ready for review June 21, 2022 15:59
@mtougeron
Copy link
Contributor Author

I don't have control to re-trigger the CI / E2E Tests (test-cli, mysql) test which was cancelled by GH actions. But this looks like it's happening on several PRs not just this one.

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@terrytangyuan
Copy link
Member

I retriggered the builds.

@mtougeron
Copy link
Contributor Author

I retriggered the builds.

Thanks!

@terrytangyuan terrytangyuan merged commit 6228748 into argoproj:master Jun 21, 2022
@mtougeron mtougeron deleted the handle-conn-reset branch June 21, 2022 16:56
@sarabala1979 sarabala1979 mentioned this pull request Jun 23, 2022
51 tasks
@sarabala1979 sarabala1979 mentioned this pull request Jul 30, 2022
51 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"connection reset by peer" transient error not handled in workflow-of-workflows
2 participants