fix: Fixed swagger error. Fixes #8922 #9078
Conversation
Signed-off-by: Teng, Jessie <yilin.teng@fmr.com>
| "google.protobuf.Any": { | ||
| "type": "object", | ||
| "properties": { | ||
| "type_url": { | ||
| "type": "string" | ||
| }, | ||
| "value": { | ||
| "type": "string", | ||
| "format": "byte" | ||
| } | ||
| } | ||
| }, | ||
| "grpc.gateway.runtime.Error": { | ||
| "type": "object", | ||
| "properties": { | ||
| "code": { | ||
| "type": "integer" | ||
| }, | ||
| "details": { | ||
| "type": "array", | ||
| "items": { | ||
| "$ref": "#/definitions/google.protobuf.Any" | ||
| } | ||
| }, | ||
| "error": { | ||
| "type": "string" | ||
| }, | ||
| "message": { | ||
| "type": "string" | ||
| } | ||
| } |
There was a problem hiding this comment.
overall looks good,
I'm not sure if we need to redefine these here though.
These are defined in api/openapi-spec/swagger.json
There was a problem hiding this comment.
Yes, we got the definitions not found error when opening pkg/apiclient/_.primary.swagger.json, so I copied them from the file you mentioned
There was a problem hiding this comment.
I think the _.primary.swagger.json is an auxiliary file that helps to construct api/openapi-spec/swagger.json
We should just validate api/openapi-spec/swagger.json
There was a problem hiding this comment.
Well, I only checked the swagger file for pkg/apiclient/_.primary.swagger.json before as the related issue is only to fix the error in it.
And I tried to open api/openapi-spec/swagger.json just now, there is no error.
Can you help to confirm if this PR is still needed or we can close the the issue and PR?
There was a problem hiding this comment.
@tczhao I saw this pull request is already approved, can we merge it or need some other actions from my side, kindly let me know if needed
|
Hi @tczhao @alexec @sarabala1979 |
|
@tczhao Thanks for your approval, can we merge this to master branch or need to ask someone else to do it? |
Signed-off-by: Teng, Jessie <yilin.teng@fmr.com> Signed-off-by: Reddy <Rajshekar.Reddy@lowes.com>
Signed-off-by: Teng, Jessie yilin.teng@fmr.com
fix: fix swagger error. Fixes #8922