Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SSH clone and proper git clone using go-git #919

Merged
merged 16 commits into from
Jul 31, 2018
Merged

Added SSH clone and proper git clone using go-git #919

merged 16 commits into from
Jul 31, 2018

Conversation

andreimc
Copy link
Contributor

SSH key from git@blah.com repos with automatic ssh-know-keys checks and using go-git for the rest of the stuff

@CLAassistant
Copy link

CLAassistant commented Jul 25, 2018

CLA assistant check
All committers have signed the CLA.

* upstream/master:
  Upgrade k8s dependencies to v1.10 (resolves #908)
  Redundant verifyResolvedVariables check in controller precluded the ability to use {{ }} in other circumstances
Copy link
Member

@jessesuen jessesuen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvements @andreimc! If you could just rebase to master I'll merge this (sorry for regenerating the dependencies from underneath you).

CHANGELOG.md Outdated
@@ -1,4 +1,7 @@
# Changelog
## 2.1.2 (2017-06-25)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The next release will be:
2.2.0 (TBD)

CHANGELOG.md Outdated
@@ -1,4 +1,7 @@
# Changelog
## 2.1.2 (2017-06-25)

- Github ssh keys
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also please feel free to add your github login (@andreimc) so that proper contribution credit can be given.

* upstream/master:
  Regenerate code and address OpenAPI rule validation errors (resolves #923)
@andreimc
Copy link
Contributor Author

@jessesuen all done mate! is there a docs repo I should add some docs about this ?

@jessesuen jessesuen merged commit 4744f45 into argoproj:master Jul 31, 2018
icecoffee531 pushed a commit to icecoffee531/argo-workflows that referenced this pull request Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants