fix: removed error check which prevented deleting successful artGC wfs. #9383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rkflows Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com>
sarabala1979
approved these changes
Aug 16, 2022
qhuai
reviewed
Aug 17, 2022
juchaosong
pushed a commit
to juchaosong/argo-workflows
that referenced
this pull request
Nov 3, 2022
…s. (argoproj#9383) fix: removed error check which prevented deleting successful artGC workflows Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com> Signed-off-by: Dillen Padhiar <dillen_padhiar@intuit.com> Signed-off-by: juchao <juchao@coscene.io>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dillen Padhiar dillen_padhiar@intuit.com
Quick fix for artifactGC. Error message check is preventing successful artifact GC workflows from being deleted. Will add better check before 3.4 release.