Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove deprecated metrics service from manifests #9399

Merged
merged 1 commit into from
Aug 23, 2022
Merged

chore: Remove deprecated metrics service from manifests #9399

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion manifests/base/workflow-controller/kustomization.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,4 @@ resources:
- workflow-controller-configmap.yaml
- workflow-controller-deployment.yaml
- workflow-controller-sa.yaml
- workflow-controller-metrics-service.yaml
- workflow-controller-priorityclass.yaml
19 changes: 0 additions & 19 deletions manifests/base/workflow-controller/workflow-controller-metrics-service.yaml
View file
Open in desktop

This file was deleted.

20 changes: 0 additions & 20 deletions manifests/quick-start-minimal.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1611,26 +1611,6 @@ spec:
selector:
app: minio
---
apiVersion: v1
kind: Service
metadata:
annotations:
workflows.argoproj.io/description: |
This service is deprecated. It will be removed in v3.4.
https://github.com/argoproj/argo-workflows/issues/8441
labels:
app: workflow-controller
name: workflow-controller-metrics
spec:
ports:
- name: metrics
port: 9090
protocol: TCP
targetPort: 9090
selector:
app: workflow-controller
---
apiVersion: scheduling.k8s.io/v1
kind: PriorityClass
metadata:
Expand Down
20 changes: 0 additions & 20 deletions manifests/quick-start-mysql.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1655,26 +1655,6 @@ spec:
selector:
app: mysql
---
apiVersion: v1
kind: Service
metadata:
annotations:
workflows.argoproj.io/description: |
This service is deprecated. It will be removed in v3.4.
https://github.com/argoproj/argo-workflows/issues/8441
labels:
app: workflow-controller
name: workflow-controller-metrics
spec:
ports:
- name: metrics
port: 9090
protocol: TCP
targetPort: 9090
selector:
app: workflow-controller
---
apiVersion: scheduling.k8s.io/v1
kind: PriorityClass
metadata:
Expand Down
20 changes: 0 additions & 20 deletions manifests/quick-start-postgres.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1655,26 +1655,6 @@ spec:
selector:
app: postgres
---
apiVersion: v1
kind: Service
metadata:
annotations:
workflows.argoproj.io/description: |
This service is deprecated. It will be removed in v3.4.
https://github.com/argoproj/argo-workflows/issues/8441
labels:
app: workflow-controller
name: workflow-controller-metrics
spec:
ports:
- name: metrics
port: 9090
protocol: TCP
targetPort: 9090
selector:
app: workflow-controller
---
apiVersion: scheduling.k8s.io/v1
kind: PriorityClass
metadata:
Expand Down