fix: use urlencode instead of htmlencode to sanitize url #9538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tianchu Zhao <evantczhao@gmail.com>
tczhao
changed the title
tczhao
changed the title
juliev0
approved these changes
Sep 7, 2022
sarabala1979
approved these changes
Sep 9, 2022
juchaosong
pushed a commit
to juchaosong/argo-workflows
that referenced
this pull request
Nov 3, 2022
fix: use urlencode instead of html encode to validate url Signed-off-by: Tianchu Zhao <evantczhao@gmail.com> Signed-off-by: Tianchu Zhao <evantczhao@gmail.com> Co-authored-by: Saravanan Balasubramanian <33908564+sarabala1979@users.noreply.github.com> Signed-off-by: juchao <juchao@coscene.io>
Closed
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HtmlEncode replaces special characters with character strings that are recognised by the HTML engine itself to render the content of the page
URLEncode replaces special characters with characters that can be understood by web browsers/web servers for the purpose of addressing
Should use URLEncode instead, since the config links are JS buttons to an external page
Fixes #9435