Don't force gzip filtering in the tar test #998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've tried this with a local build and it fixes the example workflow on #984. |
mthx
changed the title
mthx
force-pushed
the
feature/zip-artifact-fix
branch
from
d532853
to
8d4056e
Compare
`tar -tzf` will seemingly blindly filter with gzip which causes single-file ZIPs to be accidentally understood as tgz files. If we match such a tar we explode trying to untar as that call doesn't pass the option to uncompress and correctly spots that the file is not a tar. Closes argoproj#984.
mthx
force-pushed
the
feature/zip-artifact-fix
branch
from
8d4056e
to
ca89368
Compare
jessesuen
approved these changes
Sep 20, 2018
|
Thanks @mthx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tar -tfwill detect compressed tars correctly.tar -tzfwill seemingly blindly filter with gzip which causes single-file ZIPs to be accidentally understood as tgz files.If we match such a tar we explode trying to untar as that call doesn't pass the option to uncompress and correctly spots that the file is not a tar.
Closes #984.