Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize locking when processing events #602

Closed
andrii-korotkov-verkada opened this issue Jul 5, 2024 · 3 comments
Closed

Optimize locking when processing events #602

andrii-korotkov-verkada opened this issue Jul 5, 2024 · 3 comments

Comments

@andrii-korotkov-verkada
Copy link
Contributor

Sometimes it takes a while until Kubernetes event is received or processed. It could be partially related to using locks when processing events. They can be optimized to use read locks sometimes.
@andrii-korotkov-verkada
Copy link
Contributor Author

See more details about the complex issue that this tries to help with here argoproj/argo-cd#18500.

andrii-korotkov-verkada added a commit to andrii-korotkov-verkada/gitops-engine that referenced this issue Jul 5, 2024
@andrii-korotkov-verkada
chore: Optimize usage of locking in the cluster [argoproj#602]
2ab9f88 
Closes argoproj#602
Use read lock for handlers getting. Refactor updating resources in the cluster cache to only acquire lock for an update itself, not calling handlers.

Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com>
Closed
andrii-korotkov-verkada added a commit to andrii-korotkov-verkada/gitops-engine that referenced this issue Jul 5, 2024
@andrii-korotkov-verkada
chore: Optimize usage of locking in the cluster [argoproj#602]
9ae5b07 
Closes argoproj#602
Use read lock for handlers getting. Refactor updating resources in the cluster cache to only acquire lock for an update itself, not calling handlers.

Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com>
andrii-korotkov-verkada added a commit to andrii-korotkov-verkada/gitops-engine that referenced this issue Jul 6, 2024
@andrii-korotkov-verkada
chore: Optimize usage of locking in the cluster [argoproj#602]
371c4bb 
Closes argoproj#602
Use read lock for handlers getting. Refactor updating resources in the cluster cache to only acquire lock for an update itself, not calling handlers.

Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com>
andrii-korotkov-verkada added a commit to andrii-korotkov-verkada/gitops-engine that referenced this issue Jul 7, 2024
@andrii-korotkov-verkada
chore: Optimize usage of locking in the cluster [argoproj#602]
65deb76 
Closes argoproj#602
Use read lock for handlers getting. Refactor updating resources in the cluster cache to only acquire lock for an update itself, not calling handlers.

Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com>
@andrii-korotkov-verkada
Copy link
Contributor Author

Seems like this helps a lot!
#603 (comment)

andrii-korotkov-verkada added a commit to andrii-korotkov-verkada/gitops-engine that referenced this issue Jul 9, 2024
@andrii-korotkov-verkada
chore: Optimize usage of locking in the cluster [argoproj#602]
55947ce 
Closes argoproj#602
Use read lock for handlers getting. Refactor updating resources in the cluster cache to only acquire lock for an update itself, not calling handlers.

Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com>
andrii-korotkov-verkada added a commit to andrii-korotkov-verkada/gitops-engine that referenced this issue Jul 11, 2024
@andrii-korotkov-verkada
chore: Optimize usage of locking in the cluster [argoproj#602]
d5cb4d1 
Closes argoproj#602
Use read lock for handlers getting. Refactor updating resources in the cluster cache to only acquire lock for an update itself, not calling handlers.

Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com>
andrii-korotkov-verkada added a commit to andrii-korotkov-verkada/gitops-engine that referenced this issue Jul 19, 2024
@andrii-korotkov-verkada
chore: Optimize usage of locking in the cluster [argoproj#602]
637dca1 
Closes argoproj#602
Use read lock for handlers getting. Refactor updating resources in the cluster cache to only acquire lock for an update itself, not calling handlers.

Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com>
@andrii-korotkov-verkada
Copy link
Contributor Author

The testing was misleading and it actually less locking time from faster iterate hierarchy v2 that is a problem solver. A bunch of benchmarking for the lock change shows neutral-to-regression results.

@andrii-korotkov-verkada andrii-korotkov-verkada closed this as not planned Won't fix, can't repro, duplicate, stale Jul 20, 2024
Closed
@mpelekh mpelekh mentioned this issue Oct 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Optimize usage of locking in the cluster [#602] andrii-korotkov-verkada/gitops-engine
1 participant
@andrii-korotkov-verkada